chore(deps): Update go toolchain 1.24.5 and other deps#2216
Draft
matthewmcneely wants to merge 10 commits intomainfrom
Draft
chore(deps): Update go toolchain 1.24.5 and other deps#2216matthewmcneely wants to merge 10 commits intomainfrom
matthewmcneely wants to merge 10 commits intomainfrom
Conversation
…we want Helpful for local development
Was causing a race detection error on OSX
matthewmcneely
force-pushed
the
matthewmcneely/update-toolchain-1.24.5-and-other-deps
branch
from
ce74bca to
88d4f27
Compare
mangalaman93
requested changes
Aug 19, 2025
|
|
||
| # Run this script from its directory, so that badgerpb4.proto is where it's expected to | ||
| # be. | ||
| # be. Only run this script if you've made changes to the API in badgerpb4.proto. |
Contributor
There was a problem hiding this comment.
what's the harm in running it anyway?
| require.NoError(t, sw.Write(buf), "sw.Write() failed") | ||
| require.NoError(t, sw.Flush(), "sw.Flush() failed") | ||
|
|
||
| // Single defer at the end to release the final buffer |
Contributor
There was a problem hiding this comment.
there are two different buffers that we are trying to release. This does not seem right
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR upgrades the go toolchain and other deps.
Checklist
CHANGELOG.mdfile describing and linking tothis PR